qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' a


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float.
Date: Mon, 11 Oct 2010 11:26:41 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3

On 10/11/2010 11:03 AM, Markus Armbruster wrote:
As noted before, this is an incompatible change of the human monitor
command: unit now defaults to 'M'.  This must be noted*prominently*  in
the commit message.  Best in the subject.

Incompatible changes can break tools.  Quick grep of libvirt:

src/qemu/qemu_monitor_json.c:    cmd = 
qemuMonitorJSONMakeCommand("migrate_set_speed",
src/qemu/qemu_monitor_text.c:    if (virAsprintf(&cmd, "migrate_set_speed %lum", 
bandwidth)<  0) {

Looks like we're safe here.

Anthony, is this incompatibility okay?

Help should be updated in the same patch; please squash 6/7 into 5/7.

Personally, I'd rather see the patch I sent incorporated, so that there is no change in the monitor at all.

Not going to make a fuss of it as long as libvirt is okay, though.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]