Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

[Paolo Bonzini]

On 10/12/2010 04:38 PM, malc wrote:
> On Tue, 12 Oct 2010, Paolo Bonzini wrote:
>
> > On 10/12/2010 03:47 PM, malc wrote:
> > > >    # host long bits test
> > > > -hostlongbits="32"
> > > > -case "$cpu" in
> > > > -  x86_64|alpha|ia64|sparc64|ppc64|s390x)
> > > > -    hostlongbits=64
> > > > -  ;;
> > > > -esac
> > > > +cat>   $TMPC<<   EOF
> > > > +int sizeof_long_is_8[sizeof(long) == 8 ? 1 : -1];
> > > > +EOF
> > > > +if compile_object; then
> > > > +hostlongbits=64
> > > > +else
> > > > +hostlongbits=32
> > > > +fi
> > >
> > > This is wrong.
> >
> > Care to expand?
>
> Gives wrong results on Win64.

Then it's not HOST_LONG_BITS, it's HOST_POINTER_BITS.

Paolo