[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 0/4] Introduce strtosz and make use of it
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v7 0/4] Introduce strtosz and make use of it |
Date: |
Wed, 13 Oct 2010 10:24:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
address@hidden writes:
> From: Jes Sorensen <address@hidden>
>
> This patch introduces cutils.c: strtosz() and gets rid of the
> multiple custom hacks for parsing byte sizes. In addition it adds
> supports for specifying human style sizes such as 1.5G. Last it
> eliminates the horrible abuse of a float to store the byte size for
> migrate_set_speed in the monitor.
>
> Note, this is tested on Linux and build tested for win32 using
> mingw32.
>
> v7 tries to address the issues pointed out by Markus in v6
ACK
Note to maintainer: PATCH 3/4 changes migrate_set_speed.
PRO: now consistent with size arguments elsewhere
CON: incompatible change!
As far as I can tell, libvirt is not affected.
If you don't want incompatible change there, please tell us, and we'll
avoid it.