qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH][qemu-iotests] Improve test for qemu-img convert


From: Kevin Wolf
Subject: [Qemu-devel] Re: [PATCH][qemu-iotests] Improve test for qemu-img convert with backing file
Date: Fri, 15 Oct 2010 17:56:03 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7

Am 15.10.2010 16:57, schrieb Christoph Hellwig:
> On Thu, Oct 14, 2010 at 03:01:18PM +0200, Kevin Wolf wrote:
>> Additionally to testing the qemu-img convert -B option, also test
>> -o backing_file.
>>
>> Also, the old test acidentlly used a pattern of zeros for most of the writes,
>> so that the allocation test didn't really work out. This is fixed by using an
>> explicit pattern.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> ---
>>  019 |   59 ++++++++++++++++++++++++++++++++++++-----------------------
>>  1 files changed, 36 insertions(+), 23 deletions(-)
> 
> It's missing the update to the golden output an now fails.

Oops... Will send a new version.

> Btw, did you change the qemu-img check to tell people that leaked
> clusters are harmless?  That message causes 026 to fail for me with a
> recent qemu-img.

Didn't I send a patch for qemu-iotests, too? I do have local commit
updating this at least.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]