|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM |
Date: | Mon, 18 Oct 2010 12:09:23 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat/3.1.3-1.el6 Thunderbird/3.1.3 |
On 10/15/10 23:05, Anthony Liguori wrote:
On 10/15/2010 03:51 PM, Stefan Weil wrote:PCI device with different device ids sometimes share the same rom code. Only the device id and the checksum differ in a boot rom for such devices.BTW, SeaBIOS doesn't reject ROMs when they're loaded via rombar, only when they're loaded via romfile.
SeaBIOS rejects them when loaded from the rom bar and doesn't reject them when loaded via fw_cfg.
Using the rom bar is the prefered way though, fw_cfg is only there for compatibility with older versions.
Maybe it's better to use fw_cfg to explicitly tell SeaBIOS to ignore the PCI device id in the rom header for a certain device?
Patching the rom is fine IMHO. Why create + use a separate communication path when we can use a much simpler approach?
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |