[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] apic: convert debug printf statements to tracep
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] Re: [PATCH] apic: convert debug printf statements to tracepoints |
Date: |
Mon, 18 Oct 2010 13:42:53 +0100 |
Thanks for pointing out this problem with simpletrace.py. There are two
issues:
1. The regular expression used by simpletrace.py to parse trace event
declarations cannot cope with concatenated string literals.
2. Format strings must begin and end with double quotes. This was previously
undocumented but is necessary because cpp is not run over trace-events, so
parsing the strings and portability macros is non-trivial.
The follow-up patches fix the regex, add documentation for the format string
double quotes requirement, and update your patch.
simpletrace.py should work for the coalesced apic trace events now.
Stefan