qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Don't call cpu_synchronize_state() from machine


From: Scott Wood
Subject: Re: [Qemu-devel] [PATCH] Don't call cpu_synchronize_state() from machine init.
Date: Mon, 18 Oct 2010 13:32:27 -0500
User-agent: Mutt/1.5.20 (2009-06-14)

On Mon, Oct 04, 2010 at 04:15:58PM -0500, Scott Wood wrote:
> This will deadlock when the I/O thread is used, since the
> CPU thread is blocked waiting for qemu_system_ready.
> 
> The synchronization is unnecessary since this is before
> cpu_synchronize_all_post_init().
> 
> Signed-off-by: Scott Wood <address@hidden>
> ---
>  hw/ppc440_bamboo.c     |    2 --
>  hw/ppce500_mpc8544ds.c |    2 --
>  2 files changed, 0 insertions(+), 4 deletions(-)

Any comment on/objection to this patch?

-Scott

> 
> diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
> index 34ddf45..645e84f 100644
> --- a/hw/ppc440_bamboo.c
> +++ b/hw/ppc440_bamboo.c
> @@ -156,8 +156,6 @@ static void bamboo_init(ram_addr_t ram_size,
>              exit(1);
>          }
>  
> -        cpu_synchronize_state(env);
> -
>          /* Set initial guest state. */
>          env->gpr[1] = (16<<20) - 8;
>          env->gpr[3] = FDT_ADDR;
> diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
> index 1422fad..f7e9465 100644
> --- a/hw/ppce500_mpc8544ds.c
> +++ b/hw/ppce500_mpc8544ds.c
> @@ -269,8 +269,6 @@ static void mpc8544ds_init(ram_addr_t ram_size,
>              exit(1);
>          }
>  
> -        cpu_synchronize_state(env);
> -
>          /* Set initial guest state. */
>          env->gpr[1] = (16<<20) - 8;
>          env->gpr[3] = dt_base;
> -- 
> 1.7.0.4
> 
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]