qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tr


From: Prerna Saxena
Subject: [Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing
Date: Tue, 19 Oct 2010 10:46:44 +0530
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Thunderbird/3.1.3

On 10/18/2010 07:51 PM, Luiz Capitulino wrote:
On Mon, 18 Oct 2010 11:36:55 +0530
Prerna Saxena<address@hidden>  wrote:

This patch set introduces two QMP interfaces for tracing :

* query-trace        : to list current contents of trace-buffer
* query-trace-events : to list all available trace-events with their state.

This is in my to-review queue, but it's going to take a few days, because
I have to take a deeper look at the tracing feature to be able to review it.


Thanks for looking..I'd look forward to your comments :-)

Two initial questions:

  o This is labeled as an RFC, but you're versioning it. Should this be
    considered for inclusion?

I'm sending out a new version with some enhancements shortly -- for inclusion.


  o Is this really useful w/o being able to set new traces?


I'm working on that as well. The query commands are the earliest interfaces to be implemented. I will be adding interfaces to toggle the state of trace-events, set a new trace-file, etc.


Changelog :
-----------
Changes v2 ->  v3 :
- Change declarations of st_print_trace_to_qlist() and
st_print_trace_events_to_qlist() to return QList*

Changes v1 ->  v2 :
- Add 'timestamp' field for query-trace output.
- Misc cleanups.



Thanks,
--
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India



reply via email to

[Prev in Thread] Current Thread [Next in Thread]