qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 1/3] Introduce threadlets


From: Balbir Singh
Subject: Re: [Qemu-devel] Re: [PATCH 1/3] Introduce threadlets
Date: Wed, 20 Oct 2010 00:42:25 +0530
User-agent: Mutt/1.5.21 (2010-09-15)

* Paolo Bonzini <address@hidden> [2010-10-19 21:01:03]:

> On 10/19/2010 08:36 PM, Balbir Singh wrote:
> >Ideally you need
> >
> >         s = pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, NULL);
> >
> >But qemu will need to wrap this around as well.
> 
> Why?  QEMU is never using thread cancellation.
>

Yes, I agree, in the longer run, cancellation is a good way to kill
threads, specially in a thread pool. My comment was more along the
lines of good practices and potential use of pthread_cancel(), not a
strict comment on something urgent or broken. 

-- 
        Three Cheers,
        Balbir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]