|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM |
Date: | Tue, 19 Oct 2010 23:15:38 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100913 Iceowl/1.0b1 Icedove/3.0.7 |
Am 19.10.2010 10:37, schrieb Michael S. Tsirkin:
On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote:QEMU must only make sure that patching of the supported roms with supported devices work.I think that's what Anthony was saying too - make this depend on a qdev property and set it only in eepro100 for now.
My new patch v3 implements something similar and does not need a new qdev property: Don't patch because the rom file was defined by the user: qemu -L pc-bios -boot n -netdev user,id=internet \ -device i82801,netdev=internet,romfile=gpxe-eepro100-80861209.rom Patch because we work with the built-in default rom file: qemu -L pc-bios -boot n -netdev user,id=internet \ -device i82801,netdev=internet This is a safe solution which respects user's rom data without adding much more complexity. Regards, Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |