qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach
Date: Thu, 21 Oct 2010 12:00:12 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat/3.1.3-1.el6 Thunderbird/3.1.3

On 10/20/10 18:24, Luiz Capitulino wrote:
On Tue, 19 Oct 2010 15:35:01 +0200
Gerd Hoffmann<address@hidden>  wrote:

    Hi,

+        .help       = "attach USB device 'bus.addr'",

address@hidden usb_attach @var{devname}

/me sees a mismatch here.

There is still the use case question.  Also note that this might have
unwanted side effects when drivers automagically attach/detach devices
like usb-host.

Alon, did you check this? I hope it doesn't blowup.

Having this purely for debugging/troubleshooting purposes would be fine
with me, but the documentation should clearly say so.

Is this useful in production or only in the development of new devices?

I'd say more a development tool.

If
it's the letter, then I would even prefer enabling them only when DEBUG
is enabled.

Makes sense indeed.

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]