qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)
Date: Thu, 21 Oct 2010 08:13:19 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100915 Lightning/1.0b1 Thunderbird/3.0.8

On 10/21/2010 08:03 AM, Gerd Hoffmann wrote:
On 10/21/10 08:36, Alon Levy wrote:
v2->v3 changes:
  * add configure parameter
  * fix docs

v2 message:
This patchset uses id like device_del for attaching/detaching usb
devices. The first two patches ready the way:
  1. makes qdev_find_recursive non static and in qdev.h
  2. adds a usb_device_by_id which goes over the usb buses calling
   qdev_find_recursive
  3. adds the commands that use usb_device_by_id

Alon Levy (3):
   qdev: make qdev_find_recursive public
   usb: add public usb_device_by_id
   monitor: add usb_attach and usb_detach (v2)


Acked-by: Gerd Hoffmann <address@hidden>

Okay, I am still confused about the use-case for this and I don't see any further explanation in the commit messages. I've seen "debugging" but can you be a bit more specific about which cases it's needed for?

This is just adding a HMP command. Is that the right approach or was that an unintentional consequence of rebasing post-HMP/QMP split?

Regards,

Anthony Liguori


cheers,
  Gerd






reply via email to

[Prev in Thread] Current Thread [Next in Thread]