[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it |
Date: |
Fri, 22 Oct 2010 10:05:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 |
On 10/22/10 09:59, Markus Armbruster wrote:
> address@hidden writes:
>> From: Jes Sorensen <address@hidden>
>> This patch introduces cutils.c: strtosz() and gets rid of the
>> multiple custom hacks for parsing byte sizes. In addition it adds
>> supports for specifying human style sizes such as 1.5G. Last it
>> eliminates the horrible abuse of a float to store the byte size for
>> migrate_set_speed in the monitor.
>>
>> Note, this is tested on Linux and build tested for win32 using
>> mingw32.
>>
>> v9: I worked through a couple of revisions directly with Markus and I
>> think I got it right finally.
>
> I'd prefer to have strtosz() to match strtol() & friends and not
> restrict suffixes. But this code does what it claims to do, as far as I
> can see, so:
>
> ACK series
Thanks!
I thought about this a fair bit and I believe doing the full test in the
function is the most valuable. It's a personal preference obviously.
I think it's a win to do it here since it simplifies the caller code.
Would be great to get this applied so I can get it off my plate :)
Cheers,
Jes
- [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it, Jes . Sorensen, 2010/10/21
- [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count., Jes . Sorensen, 2010/10/21
- [Qemu-devel] [PATCH 2/4] Add support for 'o' octet (bytes) format as monitor parameter., Jes . Sorensen, 2010/10/21
- [Qemu-devel] [PATCH 4/4] Remove obsolete 'f' double parameter type, Jes . Sorensen, 2010/10/21
- [Qemu-devel] [PATCH 3/4] Switch migrate_set_speed() to take an 'o' argument rather than a float., Jes . Sorensen, 2010/10/21
- Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it, Markus Armbruster, 2010/10/22
- Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it,
Jes Sorensen <=