Re: [Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> From: Jan Kiszka <address@hidden>
>
> This avoids
>
>     error: zero-length gnu_printf format string
>
> Signed-off-by: Jan Kiszka <address@hidden>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  check-qjson.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/check-qjson.c b/check-qjson.c
> index 0b60e45..64fcdcb 100644
> --- a/check-qjson.c
> +++ b/check-qjson.c
> @@ -639,7 +639,9 @@ END_TEST
>  
>  START_TEST(empty_input)
>  {
> -    QObject *obj = qobject_from_json("");
> +    const char *empty = "";
> +
> +    QObject *obj = qobject_from_json(empty);
>      fail_unless(obj == NULL);
>  }
>  END_TEST

The warning is silly.  Printing nothing is unlikely to happen
unintentionally, and is perfectly well-defined and portable.

Why make the code ugly to avoid a useless warning, when we can disable
the warning?