qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] sparc32: convert debug printf statements to tra


From: Blue Swirl
Subject: [Qemu-devel] Re: [PATCH] sparc32: convert debug printf statements to tracepoints
Date: Fri, 22 Oct 2010 17:32:45 +0000

On Fri, Oct 22, 2010 at 3:22 PM, Stefan Hajnoczi
<address@hidden> wrote:
> On Thu, Oct 21, 2010 at 08:13:51PM +0000, Blue Swirl wrote:
>> Replace debug printf statements with tracepoints.
>>
>> Signed-off-by: Blue Swirl <address@hidden>
>> ---
>> There were problems with tracetool if the tracepoint string contained
>> parentheses or brackets, so I removed those.
>>
>>  hw/cs4231.c        |   20 ++-------
>>  hw/eccmemctl.c     |   46 +++++++++-------------
>>  hw/lance.c         |   14 ++-----
>>  hw/slavio_intctl.c |   38 ++++++------------
>>  hw/slavio_misc.c   |   51 ++++++++++---------------
>>  hw/slavio_timer.c  |   49 ++++++++---------------
>>  hw/sparc32_dma.c   |   42 ++++++--------------
>>  hw/sun4m.c         |   18 ++------
>>  hw/sun4m_iommu.c   |   33 ++++-----------
>>  trace-events       |  108 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  10 files changed, 213 insertions(+), 206 deletions(-)
>
> Acked-by: Stefan Hajnoczi <address@hidden>

Thanks.

> Out of interest, why is %8.8x used instead of %08x?  Is there a
> difference in meaning or just style?

Both seems to produce the same results. %08x is a bit shorter, so that
should be preferred.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]