[Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification

[Michael S. Tsirkin]

On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote:
> > > --- a/hw/pcie.h
> > > +++ b/hw/pcie.h
> > > @@ -74,6 +74,11 @@ struct PCIExpressDevice {
> > >                                   * also initialize it when loaded as
> > >                                   * appropreately.
> > >                                   */
> > > +    bool hpev_notified; /* Logical AND of conditions for hot plug event.
> > > +                         Following 6.7.3.4:
> > > +                         Software Notification of Hot-Plug Events, an 
> > > interrupt
> > > +                         is sent whenever the logical and of these 
> > > conditions
> > > +                         transitions from false to true. */
> > >  };
> > 
> > This breaks save/load.
> 
> Right. We'll need to restore this on load.
> Take a subfunction of hotplug_event_notify
> and put it in the appropriate _load function.

Or just call the notify - worst case we get an extra msi interrupt ...
Not sure whether this is required but this seems to be what we
do in virtio-pci. Up to you really ...

-- 
MST