qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks


From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks
Date: Mon, 25 Oct 2010 08:46:48 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100915 Lightning/1.0b1 Thunderbird/3.0.8

On 10/24/2010 12:38 PM, Avi Kivity wrote:
 On 10/24/2010 07:35 PM, Paolo Bonzini wrote:
On 10/24/2010 05:34 PM, Avi Kivity wrote:
A recent qemu ->  qemu-kvm merge broke cpu hotplug without the compiler
complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the other 300-odd registrations is left as an excercise
to the community.

Should we create a Documentation/ file with incomplete transitions and the commit(s) that introduced them, for volunteers who wish to do some dirty work or to learn Coccinelle?

If we have a TODO, we could add a janitor section there.

That's unnecessary work. The vast majority of the callers of register_ioport* should be using a bus specific interface instead.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]