[Qemu-devel] Re: [PATCH v4 0/9] Re-factor osdep code + macro and brace fixes

[Blue Swirl]

Thanks, applied all.

On Tue, Oct 26, 2010 at 8:39 AM,  <address@hidden> wrote:
> From: Jes Sorensen <address@hidden>
>
> Hi,
>
> Here is another set of patches which tries to split up osdep.c further
> into posix and win32 versions. It introduces oslib-{posix,win32}.c
> files which are used for functions that are OS specific core library
> functionality, like gettimeofday(), and which is used by both QEMU and
> support applications like qemu-img. Other functions are moved to
> os-{posix,win32}.c. In addtion there are a couple of minor fixes for
> bad macro names.
>
> In some cases braces were added to code when it was moved, to make it
> compliant with the QEMU bracing rules.
>
> v4 fixes the build problem for m68k-linux-user reported by Blue Swirl.
>
> Cheers,
> Jes
>
>
> Jes Sorensen (9):
>  Move QEMU OS dependant library functions to OS specific files
>  Move osdep socket code to oslib-{posix,win32}.c
>  qemu_pipe() is used only by POSIX code, so move to oslib-posix.c
>  We only support eventfd under POSIX, move qemu_eventfd() to
>    os-posix.c
>  Move qemu_gettimeofday() to OS specific files
>  Do not redefine reserved key-words TRUE/FALSE
>  Separate qemu_pidfile() into OS specific versions
>  Consolidate oom_check() functions
>  Remove unncessary includes
>
>  Makefile           |    6 +-
>  Makefile.objs      |    9 ++-
>  Makefile.target    |    2 +-
>  hw/bt-sdp.c        |   20 ++--
>  m68k-semi.c        |    2 +-
>  os-posix.c         |   53 +++++++++++
>  os-win32.c         |   24 +++++
>  osdep.c            |  256 
> ----------------------------------------------------
>  osdep.h            |   15 ---
>  oslib-posix.c      |  109 ++++++++++++++++++++++
>  oslib-win32.c      |  121 +++++++++++++++++++++++++
>  posix-aio-compat.c |    1 +
>  qemu-common.h      |    6 ++
>  qemu-img.c         |    1 +
>  qemu-malloc.c      |   14 +---
>  qemu-os-posix.h    |    3 +
>  qemu-os-win32.h    |    8 ++
>  qemu-tool.c        |    1 +
>  18 files changed, 353 insertions(+), 298 deletions(-)
>  create mode 100644 oslib-posix.c
>  create mode 100644 oslib-win32.c
>
> --
> 1.7.2.3
>
>