[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] target-xxx: Use fprintf_function (format ch
From: |
TeLeMan |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] target-xxx: Use fprintf_function (format checking) |
Date: |
Mon, 1 Nov 2010 10:24:34 +0800 |
On Sat, Oct 23, 2010 at 05:03, Stefan Weil <address@hidden> wrote:
> int eflags, i, nb;
> @@ -335,9 +333,11 @@ void cpu_dump_state(CPUState *env, FILE *f,
> (uint32_t)env->cr[2],
> (uint32_t)env->cr[3],
> (uint32_t)env->cr[4]);
> - for(i = 0; i < 4; i++)
> - cpu_fprintf(f, "DR%d=%08x ", i, env->dr[i]);
> - cpu_fprintf(f, "\nDR6=%08x DR7=%08x\n", env->dr[6], env->dr[7]);
> + for(i = 0; i < 4; i++) {
> + cpu_fprintf(f, "DR%d=" TARGET_FMT_lx " ", i, env->dr[i]);
> + }
> + cpu_fprintf(f, "\nDR6=" TARGET_FMT_lx " DR7=" TARGET_FMT_lx "\n",
> + env->dr[6], env->dr[7]);
> }
I think this patch is not right. Outputting 64bits data is not
necessary on 32bits mode.