|
From: | Andreas Färber |
Subject: | Re: [Qemu-devel] [RESEND][PATCH] Remove 16-character limit on process title |
Date: | Sun, 7 Nov 2010 15:24:34 +0100 |
Hello, Am 05.11.2010 um 17:35 schrieb John Morrissey:
qemu uses prctl() to set its process title. I bumped up against prctl()'s16-character limit recently, when adding process title support to libvirt[1][2].The attached patch overwrites argv instead. Linux seems to maintain thelength of the original args, even when the new args are shorter andNULL-terminated, so the trailing whitespace in ps(1) output is probably unavoidable. I've seen the same result with other daemons that overwriteargv.
Please use git-send-email to send it inline along with a commit message, so that it can be better reviewed and applied.
Also lacks a Signed-off-by. Please see CODING_STYLE or list archives. Andreas
john [1] https://www.redhat.com/archives/libvir-list/2010-October/msg00565.html [2] http://libvirt.org/git/?p=libvirt.git;a=commit;h=c08c7b0143b8cdc542e5f4137623d412340c5cf2 -- John Morrissey _o /\ ---- __o address@hidden _-< \_ / \ ---- < \, www.horde.net/ __(_)/_(_)________/ \_______(_) /_(_)__ <qemu-remove-process-title-length-limit.patch>
[Prev in Thread] | Current Thread | [Next in Thread] |