[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

[Gerd Hoffmann]

> > Oh, we already have a table to map pci classes to descriptions for
> > 'info pci'.  I'd strongly suggest to just add the fw names to that
> > table instead of creating a second one ...
> Do you mean pci_class_descriptions?

Exactly.

> For some classes open firmware spec
> defines single name for all subclasses. For instance all 0Axx should be
> called "dock" no matter what xx is. This can't be encoded in a simple
> table.

Well, actually it is a list not a table.  Should be easy to extend, like 
adding a mask, so you can have { .class = 0xa000, .mask = 0xff00,
.fw_name = "dock", .desc = "whatever" } to match 0xA0xx ...

cheers,
  Gerd