[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

[Michael S. Tsirkin]

On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote:
> On 11/10/10 18:34, Michael S. Tsirkin wrote:
> >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote:
> >>
> >>Signed-off-by: Gleb Natapov<address@hidden>
> >
> >Good stuff. We should also consider using this for
> >CLI and monitor. Some comments below.
> 
> Oh, we already have a table to map pci classes to descriptions for
> 'info pci'.

You remind me, that one must be fixed to use names from
pci_ids.h

>  I'd strongly suggest to just add the fw names to that
> table instead of creating a second one ...
> 
> cheers,
>   Gerd

No, I mean the path.

We are currently passing domain:bus:slot.function
to point at a device and we know it's broken for
nested bridges and kind of broken for multiple domains.
It's a bug that we must fix.

Class names aren't that interesting to me,
and I'd be just as happy with packing these into 2 tables as a single
one personally, it all seems to be a matter of style.
-- 
MST