qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] virtio-blk broken after system reset


From: Anthony Liguori
Subject: Re: [Qemu-devel] virtio-blk broken after system reset
Date: Mon, 15 Nov 2010 15:16:32 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10

On 11/13/2010 04:09 AM, Jan Kiszka wrote:

There is also real hw out there that goes into an error state if it's
misprogrammed.

I think we have to remove all those premature exits. They also prevent
handing the device inside the guest to an untrusted driver (relevant
once we have IOMMU emulation).

I think the key to achieving this is to isolate the device within QEMU.

IOW, have all fd callbacks, bottom halves, etc. tagged with a device context. Have a mechanism that raises an error on a device that can then be used to stop issuing any type of callback to the device until reset.

Obviously, we can fix some of these by just simple code refactoring.

Regards,

Anthony Liguori

Why it is trying to print things to stderr is a different
matter, it should be using a proper error-reporting routine,
but this is a different story.
Jep. Even worse: the above message is not dumped to the console as the
stream isn't flushed on exit.

Jan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]