[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT |
Date: |
Thu, 18 Nov 2010 09:02:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 11/18/10 01:41, Hidetoshi Seto wrote:
> This patch introduce a fallback mechanism for old systems that do not
> support utimensat(). This fix build failure with following warnings:
>
> hw/virtio-9p-local.c: In function 'local_utimensat':
> hw/virtio-9p-local.c:479: warning: implicit declaration of function
> 'utimensat'
> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat'
>
> and:
>
> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod':
> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this
> function)
> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once
> hw/virtio-9p.c:1410: error: for each function it appears in.)
> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this
> function)
> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod':
> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this
> function)
>
> v4:
> - Use tv_now.tv_usec
> - Rebased on latest qemu.git
> v3:
> - Use better alternative handling for UTIME_NOW/OMIT
> - Move qemu_utimensat() to cutils.c
> V2:
> - Introduce qemu_utimensat()
>
> Acked-by: Chris Wright <address@hidden>
> Acked-by: M. Mohan Kumar <address@hidden>
> Signed-off-by: Hidetoshi Seto <address@hidden>
Hi Hidetoshi,
I think the idea of the patch is good, but please move qemu_utimensat()
to oslib-posix.c and provide a wrapper for oslib-win32.c. It is
emulation for a system library function, so it doesn't belong in
cutils.c, but rather in the oslib group.
Thanks,
Jes