[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for contro
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet |
Date: |
Thu, 18 Nov 2010 12:35:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 11/16/10 02:16, Michael Roth wrote:
> Process control packets coming in over the channel. This entails setting
> up/tearing down connections to local services initiated from the other
> end of the channel.
>
> Signed-off-by: Michael Roth <address@hidden>
> ---
> virtproxy.c | 154
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 154 insertions(+), 0 deletions(-)
[snip]
> +
> + qemu_opts_print(iforward->socket_opts, NULL);
> + if (qemu_opt_get(iforward->socket_opts, "host") != NULL) {
> + server_fd = inet_connect_opts(iforward->socket_opts);
> + } else if (qemu_opt_get(iforward->socket_opts, "path") != NULL) {
> + server_fd = unix_connect_opts(iforward->socket_opts);
> + } else {
> + LOG("unable to find listening socket host/addr info");
> + return -1;
> + }
This patch is a perfect example of why -1 as an error message is suboptimal.
> + closesocket(fd);
> + vp_set_fd_handler(fd, NULL, NULL, conn);
> + QLIST_REMOVE(conn, next);
> + qemu_free(conn);
> + break;
> + }
> + }
You should never have two closing braces in the same column like this -
something is wrong with the formatting.
Cheers,
Jes
- [Qemu-devel] [RFC][PATCH v3 08/21] virtproxy: add vp_new() VPDriver constructor, (continued)
- [Qemu-devel] [RFC][PATCH v3 08/21] virtproxy: add vp_new() VPDriver constructor, Michael Roth, 2010/11/15
- [Qemu-devel] [RFC][PATCH v3 09/21] virtproxy: interfaces to set/remove/handle VPOForwards, Michael Roth, 2010/11/15
- [Qemu-devel] [RFC][PATCH v3 10/21] virtproxy: add handler for data packets, Michael Roth, 2010/11/15
- [Qemu-devel] [RFC][PATCH v3 12/21] virtproxy: add vp_handle_packet(), Michael Roth, 2010/11/15
- [Qemu-devel] [RFC][PATCH v3 13/21] virtproxy: interfaces to set/remove VPIForwards, Michael Roth, 2010/11/15
- [Qemu-devel] [RFC][PATCH v3 15/21] virtproxy: add read handler for proxied connections, Michael Roth, 2010/11/15
- [Qemu-devel] [RFC][PATCH v3 14/21] virtproxy: use new option list in virtproxy.c, Michael Roth, 2010/11/15
- [Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet, Michael Roth, 2010/11/15
- Re: [Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet,
Jes Sorensen <=
[Qemu-devel] [RFC][PATCH v3 16/21] virtproxy: add option parser helper vp_parse(), Michael Roth, 2010/11/15
[Qemu-devel] [RFC][PATCH v3 17/21] virtproxy: add virtproxy-builtin.c for compat defs, Michael Roth, 2010/11/15
[Qemu-devel] [RFC][PATCH v3 18/21] virtproxy: qemu integration, add virtproxy chardev, Michael Roth, 2010/11/15
[Qemu-devel] [RFC][PATCH v3 21/21] virtproxy: Makefile/configure changes to build qemu-vp, Michael Roth, 2010/11/15