Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

[Anthony Liguori]

On 11/18/2010 09:35 AM, Michael Roth wrote:
> > > +/* listening fd, one for each service we're forwarding to remote 
> > > end */
> > > +typedef struct VPOForward {
> > > +    VPDriver *drv;
> > > +    int listen_fd;
> > > +    char service_id[VP_SERVICE_ID_LEN];
> > > +    QLIST_ENTRY(VPOForward) next;
> > > +} VPOForward;
> >
> > I am really not a fan of the typedefmeharder approach you are taking in
> > here, but others may disagree with me.
>
>
> Isn't typedef'ing structured types part of the qemu coding style 
> guidelines?

Yes, I think Jes was just looking for an excuse to say "typedefmeharder" :-)

Regards,

Anthony Liguori