|
| From: | Anthony Liguori |
| Subject: | Re: [Qemu-devel] [PATCH v3 0/2] Type-safe ioport callbacks |
| Date: | Sun, 21 Nov 2010 09:18:49 -0600 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10 |
On 11/17/2010 03:50 AM, Avi Kivity wrote:
A not-so-recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the other 300-odd registrations is left as an excercise to the community.
Applied all. Thanks. Regards, Anthony Liguori
v3:
- define a common IORange that can also be used for mmio
- move start/length into IORange
- make access width a parameter of the access functions instead of
having a callback per access size
v2:
- const correctness
- avoid return void
Avi Kivity (2):
Type-safe ioport callbacks
piix4 acpi: convert io BAR to type-safe ioport callbacks
hw/acpi_piix4.c | 55 +++++++++++++++++++----------------------------
ioport.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
ioport.h | 2 +
iorange.h | 30 +++++++++++++++++++++++++
4 files changed, 118 insertions(+), 33 deletions(-)
create mode 100644 iorange.h
| [Prev in Thread] | Current Thread | [Next in Thread] |