qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL] More format checking


From: Stefan Weil
Subject: [Qemu-devel] [PULL] More format checking
Date: Wed, 24 Nov 2010 22:46:34 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101030 Iceowl/1.0b1 Icedove/3.0.10

Hello,

with these patches, hopefully all functions with printf like arguments
use gcc's format checking, so the TODO comment in HACKING can be removed.

The patch series was tested with a default build configuration on linux
and windows hosts (including some cross compilations for arm, mips and powerpc), so chances are good that there remain few (if any) functions without format checking.

If there remain such functions (and maybe also some related format bugs),
the compiler will raise a warning now, so it should be easy to fix them.

All patches were published on qemu-devel. There were two replies:

* 1st patch: small typo in commit message, fixed now

* last patch: breaks build

It's normal that the last patch will break builds with warning = error
as long as the other four patches (and maybe more format related fixes)
are not applied. This is the intention of the last patch!

Regards,
Stefan Weil

The following changes since commit f711df67d611e4762966a249742a5f7499e19f99:

  microblaze: target-ify target_ucontext (2010-11-23 10:04:30 +0100)

are available in the git repository at:
  git://git.weilnetz.de/git/qemu for-blueswirl

Stefan Weil (5):
      *-dis: Replace fprintf_ftype by fprintf_function (format checking)
      target-sparc: Use fprintf_function (format checking)
      audio: Use GCC_FMT_ATTR (format checking)
      darwin-user: Use GCC_FMT_ATTR (format checking)
      configure: Add compiler option -Wmissing-format-attribute

 HACKING                |    3 ---
 alpha-dis.c            |    3 +++
 arm-dis.c              |   14 +++++++-------
 audio/audio_pt_int.c   |    3 ++-
 configure              |    1 +
 darwin-user/machload.c |    2 +-
 darwin-user/qemu.h     |    2 +-
 dis-asm.h              |   10 ++--------
 m68k-dis.c             |    2 +-
 microblaze-dis.c       |    2 +-
 mips-dis.c             |    2 --
 sh4-dis.c              |   16 +++++-----------
 target-sparc/cpu.h     |    4 ++--
 13 files changed, 26 insertions(+), 38 deletions(-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]