[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation |
Date: |
Thu, 25 Nov 2010 13:47:42 +0100 |
On 25.11.2010, at 13:45, Paul Brook wrote:
>> On 25.11.2010, at 13:28, Paul Brook wrote:
>>>> Makefile.objs | 1 +
>>>> default-configs/i386-softmmu.mak | 1 +
>>>> default-configs/x86_64-softmmu.mak | 1 +
>>>
>>> Why are you only enabling this on x86? PCI devices, especially things
>>> like SATA controllers, should be completely target independent.
>>
>> Because without the mmio series it breaks on big endian devices and we have
>> to start somewhere :).
>
> less than half of the targets are big-endian. If it's broken on big-endian
> there should be a comment somewhere documenting this, so we know to fix it.
Well, it's stated in the cover letter and the same is true for almost every PCI
device in qemu we have today.
So what would you prefer? Add the device in every default config? Have a pci
combination .mak that we can include on all pci capable machines so we don't
end up patching 50 files for every device?
Alex
- [Qemu-devel] Re: [PATCH 10/12] config: Add header file for device config options, (continued)
[Qemu-devel] [PATCH 11/12] ahci: spawn controller on demand, Alexander Graf, 2010/11/23
[Qemu-devel] [PATCH 03/12] ide: add support for ide bus ops, Alexander Graf, 2010/11/23
[Qemu-devel] [PATCH 12/12] ide: move pata specific parts to pata.c, Alexander Graf, 2010/11/23
[Qemu-devel] [PATCH 02/12] ide: fix whitespace gap in ide_exec_cmd, Alexander Graf, 2010/11/23
[Qemu-devel] [PATCH 08/12] ahci: add ahci emulation, Alexander Graf, 2010/11/23
[Qemu-devel] Re: [PATCH 00/12] AHCI emulation support v4, Gerd Hoffmann, 2010/11/24