[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: qemu can die if the client is disconnected
|
From: |
malc |
|
Subject: |
Re: [Qemu-devel] [PATCH] vnc: qemu can die if the client is disconnected while updating screen |
|
Date: |
Fri, 26 Nov 2010 18:29:21 +0300 (MSK) |
|
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Fri, 26 Nov 2010, Corentin Chary wrote:
> agraf reported that qemu_mutex_destroy(vs->output_mutex) was failing
> in vnc_disconnect_finish() when the vnc client was disconnected while
> updating the screen.
>
> It's because vnc_worker_thread_loop() tries to unlock the mutex while
> not locked. The unlocking call doesn't fail (pthread bug ?), but
> the destroy call does.
>
Not bug but rather (expected in the absence of PTHREAD_MUTEX_ERRORCHECK)
undefined behaviour [1]
[1] http://www.opengroup.org/onlinepubs/7990989775/xsh/pthread_mutex_unlock.html
--
mailto:address@hidden