Re: [Qemu-devel] [PATCH 08/15] prep: Declare as little endian

[Alexander Graf]

On 26.11.2010, at 22:58, Andreas Färber wrote:

> Am 25.11.2010 um 08:35 schrieb Alexander Graf:
> 
>> This patch replaces explicit bswaps with endianness hints to the
>> mmio layer.
>> 
>> Signed-off-by: Alexander Graf <address@hidden>
> 
> I'm confused by the subject: Are you positive that PReP is little-endian? Or 
> should this read "prep: Declare some devices as little endian"?
> 
> Also, how did you test this? I did some minor prep patches to remove the 
> firmware size check and a crashing hw_error(), and kept getting some ISA IRQ 
> error a few weeks ago.
> 
> http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep

I simply replaces explicit bswaps with the flag. Testing prep is hard, as 
recent kernels don't run on it. To be honest, unless someone steps up to 
maintain it I might declare it as deprecated soon and just drop it.


Alex