[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() wi
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy(). |
Date: |
Sun, 28 Nov 2010 11:33:57 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote:
> Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let
> event-tap capture events from dma-helpers.
>
> Signed-off-by: Yoshiaki Tamura <address@hidden>
Same comment as -net here: it's not clear when should
a device use bdrv_aio_writev_proxy and when bdrv_aio_writev.
If all devices should just use _proxy, let's
just make bdrv_aio_writev DTRT instead.
> ---
> dma-helpers.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dma-helpers.c b/dma-helpers.c
> index 712ed89..8ab2c26 100644
> --- a/dma-helpers.c
> +++ b/dma-helpers.c
> @@ -117,8 +117,8 @@ static void dma_bdrv_cb(void *opaque, int ret)
> }
>
> if (dbs->is_write) {
> - dbs->acb = bdrv_aio_writev(dbs->bs, dbs->sector_num, &dbs->iov,
> - dbs->iov.size / 512, dma_bdrv_cb, dbs);
> + dbs->acb = bdrv_aio_writev_proxy(dbs->bs, dbs->sector_num, &dbs->iov,
> + dbs->iov.size / 512, dma_bdrv_cb,
> dbs);
> } else {
> dbs->acb = bdrv_aio_readv(dbs->bs, dbs->sector_num, &dbs->iov,
> dbs->iov.size / 512, dma_bdrv_cb, dbs);
> --
> 1.7.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at http://vger.kernel.org/majordomo-info.html
- [Qemu-devel] [PATCH 03/21] Introduce skip_header parameter to qemu_loadvm_state()., (continued)
- [Qemu-devel] [PATCH 03/21] Introduce skip_header parameter to qemu_loadvm_state()., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 10/21] Call init handler of event-tap at main() in vl.c., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 17/21] savevm: introduce qemu_savevm_trans_{begin, commit}., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write()., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 21/21] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 06/21] vl: add a tmp pointer so that a handler can delete the entry to which it belongs., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 20/21] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy()., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy().,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH 01/21] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 19/21] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 12/21] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 08/21] savevm: introduce util functions to control ft_trans_file from savevm layer., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 18/21] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 07/21] Introduce fault tolerant VM transaction QEMUFile and ft_mode., Yoshiaki Tamura, 2010/11/25