[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev(
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy(). |
Date: |
Mon, 29 Nov 2010 10:52:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 28.11.2010 12:55, schrieb Yoshiaki Tamura:
> 2010/11/28 Michael S. Tsirkin <address@hidden>:
>> On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote:
>>> Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let
>>> event-tap capture events from dma-helpers.
>>>
>>> Signed-off-by: Yoshiaki Tamura <address@hidden>
>>
>> Same comment as -net here: it's not clear when should
>> a device use bdrv_aio_writev_proxy and when bdrv_aio_writev.
>> If all devices should just use _proxy, let's
>> just make bdrv_aio_writev DTRT instead.
>
> Same as I replied to the net layer question. However, I had
> troubles with inserting event-tap functions into block.c before.
> block.c gets linked with utils like qemu-img, but they don't get
> linked with emulators code which event-tap uses in it. So I want
> to avoid linking block and event-tap for utils, but I guess we
> don't want to use ifdefs for this. I'm wondering how I can solve
> this problem cleanly.
>
> Kevin, do you have suggestions here?
Michael's stubs (probably in qemu-tool.c) seem to be the right solution.
Which requests do you actually want to intercept? I assume you're aware
that for example qcow2 internally calls another bdrv_aio_readv/writev
that accesses the image file.
So if you only want to have the requests that come directly from
devices, maybe you'll have to restrict it to BlockDriverStates that
belongs to a drive. I think this is the case if it has a non-empty
device name.
Kevin
- [Qemu-devel] [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write()., (continued)
- [Qemu-devel] [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write()., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 21/21] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 06/21] vl: add a tmp pointer so that a handler can delete the entry to which it belongs., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 20/21] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2010/11/25
- [Qemu-devel] [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy()., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 01/21] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 19/21] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 12/21] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 08/21] savevm: introduce util functions to control ft_trans_file from savevm layer., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 18/21] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 07/21] Introduce fault tolerant VM transaction QEMUFile and ft_mode., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 02/21] Introduce read() to FdMigrationState., Yoshiaki Tamura, 2010/11/25
[Qemu-devel] [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble., Yoshiaki Tamura, 2010/11/25