[Qemu-devel] Re: [PATCH 03/13] ide: add support for ide bus ops

[Stefan Hajnoczi]

On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf <address@hidden> wrote:
Just some cosmetic suggestions.

> @@ -2716,6 +2736,12 @@ static void ide_init1(IDEBus *bus, int unit)
>                                            ide_sector_write_timer_cb, s);
>  }
>
> +static IDEBusOps ide_bus_ops = {

Since the functions are all pata_* I think it makes sense for this to
be called pata_bus_ops, not ide_bus_ops.

> +    .transfer_start_fn = pata_transfer_start,
> +    .irq_set_fn = pata_set_irq,

irq_set or set_irq? :)  Let's consistently go with set_irq.

Stefan