Re: [Qemu-devel] [PATCH v2 0/3] vnc/spice: add monitor commands to change+expire passwords.

[Anthony Liguori]

On 11/30/2010 07:22 AM, Gerd Hoffmann wrote:
>    Hi,
>
> This patch series adds new monitor commands to set and expire
> the password:
>
>    set-password $protocol $secret
>    expire-password $protocol [ now | never | +secs | secs ]
>
> The time when the password expires can be specified either relative
> (+60 == password expires in 60 seconds from now) or absolute in seconds
> since 1970 aka unix-epoch.
>    

In the server TZ?  That's pretty nasty if you don't have a mechanism to 
figure out what the server TZ is.

Unless you have a strong desire to keep it, I would just drop the 
absolute bit.

Regards,

Anthony Liguori

> Check the patches and/or updated docs for details.
>
> cheers,
>    Gerd
>
> [ v2: remove tabs ]
>
> Gerd Hoffmann (3):
>    vnc: auth reject cleanup
>    vnc: support password expire
>    vnc/spice: add set_passwd monitor command.
>
>   console.h       |    1 +
>   hmp-commands.hx |   54 +++++++++++++++++++++++++++++
>   monitor.c       |  100 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qemu-common.h   |    3 ++
>   qmp-commands.hx |   57 +++++++++++++++++++++++++++++++
>   ui/qemu-spice.h |    5 +++
>   ui/spice-core.c |   35 +++++++++++++++++++
>   ui/vnc.c        |   44 +++++++++++++++---------
>   ui/vnc.h        |    1 +
>   9 files changed, 283 insertions(+), 17 deletions(-)
>
>
>