[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] softfloat: Rename float*_is_nan() functions
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] Re: [PATCH] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan() |
Date: |
Wed, 1 Dec 2010 20:02:52 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Dec 01, 2010 at 09:12:48AM -0800, Nathan Froyd wrote:
> On Tue, Nov 30, 2010 at 11:25:33AM +0000, Peter Maydell wrote:
> > The softfloat functions float*_is_nan() were badly misnamed,
> > because they return true only for quiet NaNs, not for all NaNs.
> > Rename them to float*_is_quiet_nan() to more accurately reflect
> > what they do.
> >
> > This change was produced by:
> > perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan)
> > (with the results manually checked.)
> >
> > Signed-off-by: Peter Maydell <address@hidden>
>
> Reviewed-by: Nathan Froyd <address@hidden>
This looks good to me too.
Acked-by: Edgar E. Iglesias <address@hidden>
Cheers