[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 5/7] Consolidate printing of block driver option
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] Re: [PATCH 5/7] Consolidate printing of block driver options |
Date: |
Mon, 6 Dec 2010 14:59:48 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Dec 06, 2010 at 03:25:38PM +0100, address@hidden wrote:
> From: Jes Sorensen <address@hidden>
>
> This consolidates the printing of block driver options in
> print_block_option_help() which is called from both img_create() and
> img_convert().
>
> This allows for the "?" detection to be done just after the parsing of
> options and the filename, instead of half way down the codepath of
> these functions.
>
> Signed-off-by: Jes Sorensen <address@hidden>
> ---
> qemu-img.c | 46 +++++++++++++++++++++++++++++++++++++---------
> 1 files changed, 37 insertions(+), 9 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
- [Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code, Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 2/7] Use qemu_mallocz() instead of calloc() in img_convert(), Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 5/7] Consolidate printing of block driver options, Jes . Sorensen, 2010/12/06
- [Qemu-devel] Re: [PATCH 5/7] Consolidate printing of block driver options,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize(), Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 6/7] Fix formatting and missing braces in qemu-img.c, Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 1/7] Add missing tracing to qemu_mallocz(), Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 7/7] Fail if detecting an unknown option, Jes . Sorensen, 2010/12/06