Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

[Jes Sorensen]

On 12/09/10 22:15, Michael Roth wrote:
> On 12/08/2010 01:22 PM, Jes Sorensen wrote:
>>> This param is kind of quirky though, size doesn't seem to have an affect
>>> for anything below 4KB, but if we stick with VA_DMESG_LEN>= 4KB this
>>> should cover us, unless it's a distro-specific. But it should blow
>>> anything up, at least.
>>
>> I am wary of these hard coded constants. Isn't there a way to set the
>> kernel's dmesg buffer size, or is that only a compile time option?
>>
> 
> From what I can tell it's a compile-time option. I originally had
> dmesg_len as a param the host could pass to the guest, but it has no
> effect if the buffer is smaller, which might cause unnecessary confusion.

You are correct! I checked, there were people talking about a
configurable option but so far it is not in place.

I would still rather have this go via a file transfer to the host, and
put the output in a tmpfile.

I am still against adding viewfile commands to the monitor though. You
get a bad control character in the string and your console is messed up.
Hit CTRL-c and you lost your guest.

Cheers,
Jes