[Qemu-devel] Re: [PATCH v2 1/2] QError: new QERR_INVALID_CPU_INDEX

[Luiz Capitulino]

On Fri, 10 Dec 2010 14:36:01 +0800
Lai Jiangshan <address@hidden> wrote:

> 
> Signed-off-by:  Lai Jiangshan <address@hidden>

As Markus said, we report this as an invalid parameter in do_cpu(), we can do
the same for inject-nmi.

> ---
> diff --git a/qerror.c b/qerror.c
> index ac2cdaf..f59fb58 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -117,6 +117,10 @@ static const QErrorStringTable qerror_table[] = {
>          .desc      = "Invalid block format '%(name)'",
>      },
>      {
> +        .error_fmt = QERR_INVALID_CPU_INDEX,
> +        .desc      = "Invalid CPU index '%(cpu_index)'",
> +    },
> +    {
>          .error_fmt = QERR_INVALID_PARAMETER,
>          .desc      = "Invalid parameter '%(name)'",
>      },
> diff --git a/qerror.h b/qerror.h
> index 943a24b..9117dda 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -102,6 +102,9 @@ QError *qobject_to_qerror(const QObject *obj);
>  #define QERR_INVALID_BLOCK_FORMAT \
>      "{ 'class': 'InvalidBlockFormat', 'data': { 'name': %s } }"
>  
> +#define QERR_INVALID_CPU_INDEX \
> +    "{ 'class': 'InvalidCPUIndex', 'data': { 'cpu_index': %d } }"
> +
>  #define QERR_INVALID_PARAMETER \
>      "{ 'class': 'InvalidParameter', 'data': { 'name': %s } }"
>  
>