[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] ide: add TRIM support
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] ide: add TRIM support |
Date: |
Fri, 10 Dec 2010 14:39:41 +0100 |
User-agent: |
Mutt/1.3.28i |
On Thu, Dec 02, 2010 at 03:07:49PM +0100, Kevin Wolf wrote:
> This looks wrong. Wouldn't werror=stop cause the request to be retried
> as a write when the VM is resumed?
Indeed.
> But having a copy&paste error gives just about right reason to mention
> that after read and write this is the third almost unchanged copy of
> this code. Eventually we'll want to refactor this.
I've added a patch to refactor the DMA code to the next iteration
of the patch series.
> While we're at it, do you know why in the eot: case we set
> BM_STATUS_INT, but don't actually call ide_set_irq? From what I
> understand, those two should always be coupled, but I might be wrong.
No idea, sorry.
[Qemu-devel] [PATCH 2/5] scsi-disk: support WRITE SAME (16) with unmap bit, Christoph Hellwig, 2010/12/01
[Qemu-devel] [PATCH 3/5] make dma_bdrv_io available to drivers, Christoph Hellwig, 2010/12/01
[Qemu-devel] [PATCH 4/5] ide: add TRIM support, Christoph Hellwig, 2010/12/01
[Qemu-devel] [PATCH 5/5] raw-posix: add discard support, Christoph Hellwig, 2010/12/01