[Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host

[Amit Shah]

On (Fri) Dec 10 2010 [15:17:18], Paul Brook wrote:
> > On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > > > -        if (!discard) {
> > > > +        if (discard) {
> > > > +            goto next;
> > > > +        }
> > > > 
> > > > +    next:
> > > >          virtqueue_push(vq, &elem, 0);
> > > 
> > > Please don't do this.
> > 
> > Could you elaborate?
> > 
> > I can move the 'discard' check into the following 'for' loop, but since
> > the value of discard doesn't change, I moved it outside.
> 
> You've replaced a perfectly good if block with a goto.

To keep the indentation levels low.

I've put it in the for loop for v2.

                Amit