Re: [Qemu-devel] [PATCH 0/6] usb-ccid (v8)

[Alon Levy]

On Sun, Dec 12, 2010 at 03:07:52PM +0000, Blue Swirl wrote:
<snip>
> 
> There is a typo in configure:
> diff --git a/configure b/configure
> index 4b55904..7288b09 100755
> --- a/configure
> +++ b/configure
> @@ -2142,7 +2142,7 @@ if test "$smartcard" != "no" ; then
>      QEMU_CFLAGS="$QEMU_CFLAGS $smartcard_cflags $libcaccard_cflags"
>      LIBS="$libcaccard_libs $LIBS"
>    else
> -    if test "smartcard" = "yes" ; then
> +    if test "$smartcard" = "yes" ; then
>        feature_not_found "smartcard"
>      fi
>      smartcard="no"
> 
> Build also fails when compiling in an object directory:
> make: *** libcaccard: No such file or directory.  Stop.
> make: *** [subdir-libcaccard] Error 2
> 
ok, will fix.

> I'd even remove the configure option and build the card by default if
> the dependencies are found.
> 
ok, good idea.

> There were also whitespace problems when applying:
> Applying ccid: add ccid-card-emulated device (v2)
> .dotest/patch:37: trailing whitespace.
>  *  for i in 1 2 3; do certutil -d /etc/pki/nssdb -x -t "CT,CT,CT" -S
> -s "CN=user$i" -n user$i; done
> warning: 1 line applied after fixing whitespace errors.
> Applying ccid: add docs
> .dotest/patch:121: trailing whitespace.
>                             [APDU<->APDU repeats several times]
> warning: 1 line applied after fixing whitespace errors.
> 
will fix as well.