Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

[Peter Maydell]

On 18 December 2010 02:30, Nathan Froyd <address@hidden> wrote:
> I wouldn't be too worried:
>
> typedef uint8_t flag;
> typedef uint8_t uint8;
> typedef int8_t int8;
> typedef int uint16;
> typedef int int16;
> typedef unsigned int uint32;
> typedef signed int int32;
> typedef uint64_t uint64;
> typedef int64_t int64;
>
> So adding _t suffixes in appropriate places should be a no-op, except
> for uint16/int16--and those types are never used.

Eh? If you comment out the int16 typedef you'll find softfloat.c
doesn't compile because of all the places it's used... (uint16
isn't used, though.) A lot of the int16 uses are things like shift counts
which should probably go to plain old 'int' rather than 'int16_t'.

Also, are we sure we want to throw away the current information
in the code about the distinction between "I need at least X bits"
and "I need exactly X bits" ?

-- PMM