[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] scsi-generic and max request size
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] scsi-generic and max request size |
Date: |
Thu, 23 Dec 2010 00:49:08 +0100 |
On 23.12.2010, at 00:44, Benjamin Herrenschmidt wrote:
> On Thu, 2010-12-23 at 00:39 +0100, Alexander Graf wrote:
>> This all belongs in the block layer. If you create a call back
>> function or property in the block struct, windows can implement its
>> own limits when someone sits down to implement SG_IO on Windows.
>
> Right and we do have "generic" ways it seems to interrogate those
> limits .. except they seem to be broken for "sg" :-)
>
> Also I've spotted some oddities where the ioctl for the max request size
> sometimes put_user as a int * and sometimes as a short * ... ooops...
Congratulations for finding lots of Linux bugs :). Look at it from that way:
You'll most likely be the very first person actually using sg properly. So
after you're done, others won't have to fix it :).
Alex
- Re: [Qemu-devel] scsi-generic and max request size, (continued)
- Re: [Qemu-devel] scsi-generic and max request size, Benjamin Herrenschmidt, 2010/12/21
- Re: [Qemu-devel] scsi-generic and max request size, Hannes Reinecke, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Christoph Hellwig, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Benjamin Herrenschmidt, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Alexander Graf, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Benjamin Herrenschmidt, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Alexander Graf, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Benjamin Herrenschmidt, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Alexander Graf, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size, Benjamin Herrenschmidt, 2010/12/22
- Re: [Qemu-devel] scsi-generic and max request size,
Alexander Graf <=
- Re: [Qemu-devel] scsi-generic and max request size, Benjamin Herrenschmidt, 2010/12/22