[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migratio
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari). |
Date: |
Mon, 27 Dec 2010 10:56:17 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote:
> When -k option is set to migrate command, it will turn on ft_mode to
> start FT migration mode (Kemari).
>
> Signed-off-by: Yoshiaki Tamura <address@hidden>
> ---
> hmp-commands.hx | 7 ++++---
> migration.c | 3 +++
> qmp-commands.hx | 7 ++++---
> 3 files changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 4befbe2..0071409 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -735,13 +735,14 @@ ETEXI
>
> {
> .name = "migrate",
> - .args_type = "detach:-d,blk:-b,inc:-i,uri:s",
> - .params = "[-d] [-b] [-i] uri",
> + .args_type = "detach:-d,blk:-b,inc:-i,ft:-k,uri:s",
> + .params = "[-d] [-b] [-i] [-k] uri",
> .help = "migrate to URI (using -d to not wait for completion)"
> "\n\t\t\t -b for migration without shared storage with"
> " full copy of disk\n\t\t\t -i for migration without "
> "shared storage with incremental copy of disk "
> - "(base image shared between src and destination)",
> + "(base image shared between src and destination)"
> + "\n\t\t\t -k for FT migration mode (Kemari)",
FT -> Fault tolerance?
IMO it's preferrable to avoid abbreviations in the documentation.
Not sure whether we need to mention the codename here: is it likely to
help the users?
> .user_print = monitor_user_noop,
> .mhandler.cmd_new = do_migrate,
> },
> diff --git a/migration.c b/migration.c
> index 0db0b6d..a4a39eb 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -92,6 +92,9 @@ int do_migrate(Monitor *mon, const QDict *qdict, QObject
> **ret_data)
> return -1;
> }
>
> + if (qdict_get_try_bool(qdict, "ft", 0))
> + ft_mode = FT_INIT;
> +
> if (strstart(uri, "tcp:", &p)) {
> s = tcp_start_outgoing_migration(mon, p, max_throttle, detach,
> blk, inc);
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 3486223..b28bf70 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -431,13 +431,14 @@ EQMP
>
> {
> .name = "migrate",
> - .args_type = "detach:-d,blk:-b,inc:-i,uri:s",
> - .params = "[-d] [-b] [-i] uri",
> + .args_type = "detach:-d,blk:-b,inc:-i,ft:-k,uri:s",
> + .params = "[-d] [-b] [-i] [-k] uri",
> .help = "migrate to URI (using -d to not wait for completion)"
> "\n\t\t\t -b for migration without shared storage with"
> " full copy of disk\n\t\t\t -i for migration without "
> "shared storage with incremental copy of disk "
> - "(base image shared between src and destination)",
> + "(base image shared between src and destination)"
> + "\n\t\t\t -k for FT migration mode (Kemari)",
> .user_print = monitor_user_noop,
> .mhandler.cmd_new = do_migrate,
> },
> --
> 1.7.1.2
- [Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer., (continued)
- [Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write()., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 06/19] virtio: decrement last_avail_idx with inuse before saving., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay()., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush()., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state()., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).,
Michael S. Tsirkin <=
- [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2010/12/27
- [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Michael S. Tsirkin, 2010/12/27
- Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2010/12/27
- Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Avi Kivity, 2010/12/27
- Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2010/12/27
- Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Michael S. Tsirkin, 2010/12/27
- Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2010/12/27
[Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2010/12/27
[Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c., Yoshiaki Tamura, 2010/12/27
[Qemu-devel] [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2010/12/27