[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: Fix translation of unary PPC/SPE instructions (efdneg e
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] Re: Fix translation of unary PPC/SPE instructions (efdneg etc.). |
Date: |
Sat, 1 Jan 2011 14:12:17 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Jan 01, 2011 at 01:13:52PM +0100, Andreas Färber wrote:
> Hello Aurelien,
>
> Commit 6d5c34fa027d1477c0572ea74421e21b0f733838 appears to have not been
> on the mailing list as a patch and does not have an Acked-by from Alex as
> target-ppc/ maintainer.
>
It has been posted here as a bug report and hence appeared on the
mailing list:
http://www.mail-archive.com/address@hidden/msg39775.html
It was before Alex declared himself as the PPC maintainer, that is at
the time I was still the de facto maintainer, committing most of the
PPC patches. I simply had it in my queue branch and forgot to push it
until now.
> While the change itself looks correct to me on a brief look, the commit
> message is lacking a description of what was wrong (rD vs. rA
> apparently). Please don't commit directly so that these kind of things
> can be caught and tested by more people before it's too late.
>
It has been reviewed by Nathan Froyd and myself.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net