[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] target-ppc: use float32_is_any_nan()
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] Re: [PATCH] target-ppc: use float32_is_any_nan() |
Date: |
Wed, 5 Jan 2011 18:19:08 +0100 |
On 05.01.2011, at 18:14, Peter Maydell wrote:
> On 5 January 2011 16:59, Alexander Graf <address@hidden> wrote:
>>
>> On 02.01.2011, at 13:06, Aurelien Jarno wrote:
>>
>>> Use the new function float32_is_any_nan() instead of
>>> float32_is_quiet_nan() || float32_is_signaling_nan().
>>>
>>> Cc: Alexander Graf <address@hidden>
>>> Signed-off-by: Aurelien Jarno <address@hidden>
>>
>> I frankly have very little knowledge of FP stuff. Is any_nan really equal to
>> quiet_nan || signaling_nan or would it cover more cases?
>
> It is exactly equivalent -- all NaNs are either signalling or quiet.
>
> (If you want to check this you don't need to know anything about floating
> point, all three functions are just acting on 32 bit values so you could
> in theory identify all the bit patterns they return true or false on...)
Yeah, reading on through the FP parts of the spec I realized that too :).
Thanks for the clarification.
Acked-by: Alexander Graf <address@hidden>
Alex