Re: [Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional operation.

[Richard Henderson]

On 01/09/2011 01:38 PM, Aurelien Jarno wrote:
> The encoding of the constant part actually doesn't match the one in the
> C function where two arguments are separated and not encoded. What about
> adding a tcg_gen_op5ii_i32/64 function and having the two arguments
> separated?

I certainly didn't want to expose the combined argument to the target
translators.  I had thought that saving some memory by combining the
two constants would be a good idea, but perhaps you're right that it's
overly complicated for the benefit.

> Also what about a shorter name, like for example 'dep' as it is used on
> some architectures.

I suppose.  I thought perhaps that would be too cryptic though.


r~