[Qemu-devel] Re: [PATCH] audio: split sample conversion and volumemixing

[Michael Walle]

Hi Wolfgang,

> The fixed point path for scaling in mixeng_volume() seems to be under by
> a factor of two, IMHO. The right shift should be by 31, not 32. (Because
> the volume, which I assume is a signed 32 bit integer, can be 0.5 at
> most).
I must admit i just copied the shift from the original define. But the volume 
and the samples are signed 64bit values.

@malc: any comments on this?

> Does the code work with FLOAT_MIXENG undefined?
At least for my input voice, it works with integer arithmetic. 

-- 
  Michael