|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n |
Date: | Fri, 14 Jan 2011 08:31:51 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 01/13/2011 06:28 PM, David Ahern wrote:
@@ -1087,8 +1087,10 @@ void pc_vga_init(PCIBus *pci_bus) } else if (std_vga_enabled) { if (pci_bus) { pci_vga_init(pci_bus); +#ifdef CONFIG_VGA_ISA } else { isa_vga_init(); +#endifShould this be an abort for #ifndef CONFIG_VGA_ISA? And maybe the isapc machine should be disabled altogether? PaoloIf that's desired I can change that to: #ifdef CONFIG_VGA_ISA } else { isa_vga_init(); #else abort(); #endif
Please check if you can trigger the abort via -M isapc (I think so, but I'm not sure). If I am correct, the better solution is to disable isapc.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |